Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Implement state filter and multi select filters #27

Merged
merged 17 commits into from
Nov 7, 2024
Merged

[feat] Implement state filter and multi select filters #27

merged 17 commits into from
Nov 7, 2024

Conversation

kylezryr
Copy link
Collaborator

What's new in this PR 🧑‍🌾

Description

  • Implemented state filter dropdown
  • Split FilterDropdown components into separate single and multiple select components
  • Added a default screen prompting the user to select a state before viewing PlantList

Screenshots

How to review

Next steps

  • Styling!!

Relevant links

Online sources

https://linear.app/trap-garden/issue/TG-26/implement-state-filter-and-multi-select-filters

Related PRs

CC: @ccatherinetan

@kylezryr kylezryr linked an issue Oct 26, 2024 that may be closed by this pull request
Implement State Filter and Multi-Select Filters #19
Closed
ccatherinetan
ccatherinetan reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@ccatherinetan ccatherinetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking amazing!
ik we talked about styling stuff / resizing of the buttons, but i honestly wouldn't worry too much about it. after the 2 comments i left are addressed, we're ready to merge!

package-lock.json Outdated Show resolved Hide resolved
app/seasonal-planting-guide/page.tsx Outdated Show resolved Hide resolved
@kylezryr kylezryr force-pushed the 19-implement-state-filter-and-multi-select-filters branch from fcc6aef to 7be66e3 Compare November 4, 2024 01:03
ccatherinetan
ccatherinetan reviewed Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@ccatherinetan ccatherinetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great! a couple things

  1. styling of the "Search Plants" button (lower priority, can be pushed to later)
  2. making use of the label/values in MultiSelectDropdown

components/SearchBar/styles.ts Show resolved Hide resolved
app/seasonal-planting-guide/page.tsx Outdated Show resolved Hide resolved
components/FilterDropdownMultiple.tsx Outdated Show resolved Hide resolved
components/SearchBar/SearchBar.tsx Outdated Show resolved Hide resolved
@itsliterallymonique itsliterallymonique mentioned this pull request Nov 5, 2024
Closed
kylezryr and others added 17 commits November 6, 2024 20:05
@kylezryr @ccatherinetan
change dropdowns to multi select
a082a1a
@kylezryr @ccatherinetan
move checking functions to utils
6586c22
@kylezryr @ccatherinetan
added us state dropdown, split dropdown component into single and mul…
a215ae7 
…tiple select
@kylezryr @ccatherinetan
added default screen before state is selected
a9d35b6
@kylezryr @ccatherinetan
fix eslint errors
5ee7bb7
@kylezryr @ccatherinetan
rebase and add search bar
c91282d
@kylezryr @ccatherinetan
changed state buttons to dropdown
4958a12
@kylezryr @ccatherinetan
change dropdowns to multi select
ac7a875
@kylezryr @ccatherinetan
added us state dropdown, split dropdown component into single and mul…
f6f6ff4 
…tiple select
@kylezryr @ccatherinetan
added default screen before state is selected
6c51531
@kylezryr @ccatherinetan
rebase and add search bar
bc71295
@kylezryr @ccatherinetan
undo changes to plantdetails
144f55e
@kylezryr @ccatherinetan
undo changes to add-details
d042a96
@kylezryr @ccatherinetan
added useMemo to filteredPlantList
7728e68
@kylezryr @ccatherinetan
change dropdown values to be upper case
da8bb8f
@kylezryr @ccatherinetan
change search bar input and options prop for filter dropdown
cbae88c
@ccatherinetan
fix filteredPlantList dependencies
3a58545
@ccatherinetan ccatherinetan force-pushed the 19-implement-state-filter-and-multi-select-filters branch from 370eee1 to 3a58545 Compare November 7, 2024 04:25
ccatherinetan
ccatherinetan approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@ccatherinetan ccatherinetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! tysm kyle! i rebased, and it's ready to push!

@ccatherinetan ccatherinetan merged commit 40894a7 into main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccatherinetan ccatherinetan ccatherinetan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement State Filter and Multi-Select Filters
2 participants
@kylezryr @ccatherinetan